Merge pull request '[PR]: perf: enforce redis with TTL to cache' (#10397) from nmkj/calckey:replace-cache into develop

Reviewed-on: https://codeberg.org/calckey/calckey/pulls/10397
This commit is contained in:
Kainoa Kanter 2023-07-03 03:23:19 +00:00
commit 2968d17bc5
20 changed files with 210 additions and 140 deletions

View File

@ -34,6 +34,7 @@
"@koa/cors": "3.4.3", "@koa/cors": "3.4.3",
"@koa/multer": "3.0.2", "@koa/multer": "3.0.2",
"@koa/router": "9.0.1", "@koa/router": "9.0.1",
"@msgpack/msgpack": "3.0.0-beta2",
"@peertube/http-signature": "1.7.0", "@peertube/http-signature": "1.7.0",
"@redocly/openapi-core": "1.0.0-beta.120", "@redocly/openapi-core": "1.0.0-beta.120",
"@sinonjs/fake-timers": "9.1.2", "@sinonjs/fake-timers": "9.1.2",
@ -43,7 +44,6 @@
"ajv": "8.12.0", "ajv": "8.12.0",
"archiver": "5.3.1", "archiver": "5.3.1",
"argon2": "^0.30.3", "argon2": "^0.30.3",
"async-mutex": "^0.4.0",
"autobind-decorator": "2.4.0", "autobind-decorator": "2.4.0",
"autolinker": "4.0.0", "autolinker": "4.0.0",
"autwh": "0.1.0", "autwh": "0.1.0",

View File

@ -1,43 +1,85 @@
import { redisClient } from "@/db/redis.js";
import { encode, decode } from "@msgpack/msgpack";
import { ChainableCommander } from "ioredis";
export class Cache<T> { export class Cache<T> {
public cache: Map<string | null, { date: number; value: T }>; private ttl: number;
private lifetime: number; private prefix: string;
constructor(lifetime: Cache<never>["lifetime"]) { constructor(name: string, ttlSeconds: number) {
this.cache = new Map(); this.ttl = ttlSeconds;
this.lifetime = lifetime; this.prefix = `cache:${name}`;
} }
public set(key: string | null, value: T): void { private prefixedKey(key: string | null): string {
this.cache.set(key, { return key ? `${this.prefix}:${key}` : this.prefix;
date: Date.now(),
value,
});
} }
public get(key: string | null): T | undefined { public async set(
const cached = this.cache.get(key); key: string | null,
if (cached == null) return undefined; value: T,
if (Date.now() - cached.date > this.lifetime) { transaction?: ChainableCommander,
this.cache.delete(key); ): Promise<void> {
return undefined; const _key = this.prefixedKey(key);
} const _value = Buffer.from(encode(value));
return cached.value; const commander = transaction ?? redisClient;
await commander.set(_key, _value, "EX", this.ttl);
} }
public delete(key: string | null) { public async get(key: string | null, renew = false): Promise<T | undefined> {
this.cache.delete(key); const _key = this.prefixedKey(key);
const cached = await redisClient.getBuffer(_key);
if (cached === null) return undefined;
if (renew) await redisClient.expire(_key, this.ttl);
return decode(cached) as T;
}
public async getAll(renew = false): Promise<Map<string, T>> {
const keys = await redisClient.keys(`${this.prefix}*`);
const map = new Map<string, T>();
if (keys.length === 0) {
return map;
}
const values = await redisClient.mgetBuffer(keys);
for (const [i, key] of keys.entries()) {
const val = values[i];
if (val !== null) {
map.set(key, decode(val) as T);
}
}
if (renew) {
const trans = redisClient.multi();
for (const key of map.keys()) {
trans.expire(key, this.ttl);
}
await trans.exec();
}
return map;
}
public async delete(...keys: (string | null)[]): Promise<void> {
if (keys.length > 0) {
const _keys = keys.map(this.prefixedKey);
await redisClient.del(_keys);
}
} }
/** /**
* fetcherを呼び出して結果をキャッシュ& * Returns if cached value exists. Otherwise, calls fetcher and caches.
* optional: キャッシュが存在してもvalidatorでfalseを返すとキャッシュ無効扱いにします * Overwrites cached value if invalidated by the optional validator.
*/ */
public async fetch( public async fetch(
key: string | null, key: string | null,
fetcher: () => Promise<T>, fetcher: () => Promise<T>,
renew = false,
validator?: (cachedValue: T) => boolean, validator?: (cachedValue: T) => boolean,
): Promise<T> { ): Promise<T> {
const cachedValue = this.get(key); const cachedValue = await this.get(key, renew);
if (cachedValue !== undefined) { if (cachedValue !== undefined) {
if (validator) { if (validator) {
if (validator(cachedValue)) { if (validator(cachedValue)) {
@ -52,20 +94,21 @@ export class Cache<T> {
// Cache MISS // Cache MISS
const value = await fetcher(); const value = await fetcher();
this.set(key, value); await this.set(key, value);
return value; return value;
} }
/** /**
* fetcherを呼び出して結果をキャッシュ& * Returns if cached value exists. Otherwise, calls fetcher and caches if the fetcher returns a value.
* optional: キャッシュが存在してもvalidatorでfalseを返すとキャッシュ無効扱いにします * Overwrites cached value if invalidated by the optional validator.
*/ */
public async fetchMaybe( public async fetchMaybe(
key: string | null, key: string | null,
fetcher: () => Promise<T | undefined>, fetcher: () => Promise<T | undefined>,
renew = false,
validator?: (cachedValue: T) => boolean, validator?: (cachedValue: T) => boolean,
): Promise<T | undefined> { ): Promise<T | undefined> {
const cachedValue = this.get(key); const cachedValue = await this.get(key, renew);
if (cachedValue !== undefined) { if (cachedValue !== undefined) {
if (validator) { if (validator) {
if (validator(cachedValue)) { if (validator(cachedValue)) {
@ -81,7 +124,7 @@ export class Cache<T> {
// Cache MISS // Cache MISS
const value = await fetcher(); const value = await fetcher();
if (value !== undefined) { if (value !== undefined) {
this.set(key, value); await this.set(key, value);
} }
return value; return value;
} }

View File

@ -11,7 +11,7 @@ import * as Acct from "@/misc/acct.js";
import type { Packed } from "./schema.js"; import type { Packed } from "./schema.js";
import { Cache } from "./cache.js"; import { Cache } from "./cache.js";
const blockingCache = new Cache<User["id"][]>(1000 * 60 * 5); const blockingCache = new Cache<User["id"][]>("blocking", 60 * 5);
// NOTE: フォローしているユーザーのノート、リストのユーザーのノート、グループのユーザーのノート指定はパフォーマンス上の理由で無効になっている // NOTE: フォローしているユーザーのノート、リストのユーザーのノート、グループのユーザーのノート指定はパフォーマンス上の理由で無効になっている

View File

@ -1,33 +1,41 @@
import probeImageSize from "probe-image-size"; import probeImageSize from "probe-image-size";
import { Mutex, withTimeout } from "async-mutex"; import { Mutex } from "redis-semaphore";
import { FILE_TYPE_BROWSERSAFE } from "@/const.js"; import { FILE_TYPE_BROWSERSAFE } from "@/const.js";
import Logger from "@/services/logger.js"; import Logger from "@/services/logger.js";
import { Cache } from "./cache.js"; import { Cache } from "./cache.js";
import { redisClient } from "@/db/redis.js";
export type Size = { export type Size = {
width: number; width: number;
height: number; height: number;
}; };
const cache = new Cache<boolean>(1000 * 60 * 10); // once every 10 minutes for the same url const cache = new Cache<boolean>("emojiMeta", 60 * 10); // once every 10 minutes for the same url
const mutex = withTimeout(new Mutex(), 1000);
export async function getEmojiSize(url: string): Promise<Size> {
const logger = new Logger("emoji"); const logger = new Logger("emoji");
await mutex.runExclusive(() => { export async function getEmojiSize(url: string): Promise<Size> {
const attempted = cache.get(url); let attempted = true;
const lock = new Mutex(redisClient, "getEmojiSize");
await lock.acquire();
try {
attempted = (await cache.get(url)) === true;
if (!attempted) { if (!attempted) {
cache.set(url, true); await cache.set(url, true);
} else { }
} finally {
await lock.release();
}
if (attempted) {
logger.warn(`Attempt limit exceeded: ${url}`); logger.warn(`Attempt limit exceeded: ${url}`);
throw new Error("Too many attempts"); throw new Error("Too many attempts");
} }
});
try { try {
logger.info(`Retrieving emoji size from ${url}`); logger.debug(`Retrieving emoji size from ${url}`);
const { width, height, mime } = await probeImageSize(url, { const { width, height, mime } = await probeImageSize(url, {
timeout: 5000, timeout: 5000,
}); });

View File

@ -3,10 +3,12 @@ import type { User } from "@/models/entities/user.js";
import type { UserKeypair } from "@/models/entities/user-keypair.js"; import type { UserKeypair } from "@/models/entities/user-keypair.js";
import { Cache } from "./cache.js"; import { Cache } from "./cache.js";
const cache = new Cache<UserKeypair>(Infinity); const cache = new Cache<UserKeypair>("keypairStore", 60 * 30);
export async function getUserKeypair(userId: User["id"]): Promise<UserKeypair> { export async function getUserKeypair(userId: User["id"]): Promise<UserKeypair> {
return await cache.fetch(userId, () => return await cache.fetch(
UserKeypairs.findOneByOrFail({ userId: userId }), userId,
() => UserKeypairs.findOneByOrFail({ userId: userId }),
true,
); );
} }

View File

@ -7,8 +7,9 @@ import { isSelfHost, toPunyNullable } from "./convert-host.js";
import { decodeReaction } from "./reaction-lib.js"; import { decodeReaction } from "./reaction-lib.js";
import config from "@/config/index.js"; import config from "@/config/index.js";
import { query } from "@/prelude/url.js"; import { query } from "@/prelude/url.js";
import { redisClient } from "@/db/redis.js";
const cache = new Cache<Emoji | null>(1000 * 60 * 60 * 12); const cache = new Cache<Emoji | null>("populateEmojis", 60 * 60 * 12);
/** /**
* *
@ -75,7 +76,7 @@ export async function populateEmoji(
if (emoji && !(emoji.width && emoji.height)) { if (emoji && !(emoji.width && emoji.height)) {
emoji = await queryOrNull(); emoji = await queryOrNull();
cache.set(cacheKey, emoji); await cache.set(cacheKey, emoji);
} }
if (emoji == null) return null; if (emoji == null) return null;
@ -150,7 +151,7 @@ export async function prefetchEmojis(
emojis: { name: string; host: string | null }[], emojis: { name: string; host: string | null }[],
): Promise<void> { ): Promise<void> {
const notCachedEmojis = emojis.filter( const notCachedEmojis = emojis.filter(
(emoji) => cache.get(`${emoji.name} ${emoji.host}`) == null, async (emoji) => !(await cache.get(`${emoji.name} ${emoji.host}`)),
); );
const emojisQuery: any[] = []; const emojisQuery: any[] = [];
const hosts = new Set(notCachedEmojis.map((e) => e.host)); const hosts = new Set(notCachedEmojis.map((e) => e.host));
@ -169,7 +170,9 @@ export async function prefetchEmojis(
select: ["name", "host", "originalUrl", "publicUrl"], select: ["name", "host", "originalUrl", "publicUrl"],
}) })
: []; : [];
const trans = redisClient.multi();
for (const emoji of _emojis) { for (const emoji of _emojis) {
cache.set(`${emoji.name} ${emoji.host}`, emoji); cache.set(`${emoji.name} ${emoji.host}`, emoji, trans);
} }
await trans.exec();
} }

View File

@ -1,4 +1,3 @@
import { URL } from "url";
import { In, Not } from "typeorm"; import { In, Not } from "typeorm";
import Ajv from "ajv"; import Ajv from "ajv";
import type { ILocalUser, IRemoteUser } from "@/models/entities/user.js"; import type { ILocalUser, IRemoteUser } from "@/models/entities/user.js";
@ -40,7 +39,10 @@ import {
} from "../index.js"; } from "../index.js";
import type { Instance } from "../entities/instance.js"; import type { Instance } from "../entities/instance.js";
const userInstanceCache = new Cache<Instance | null>(1000 * 60 * 60 * 3); const userInstanceCache = new Cache<Instance | null>(
"userInstance",
60 * 60 * 3,
);
type IsUserDetailed<Detailed extends boolean> = Detailed extends true type IsUserDetailed<Detailed extends boolean> = Detailed extends true
? Packed<"UserDetailed"> ? Packed<"UserDetailed">

View File

@ -5,7 +5,6 @@ import type {
CacheableRemoteUser, CacheableRemoteUser,
CacheableUser, CacheableUser,
} from "@/models/entities/user.js"; } from "@/models/entities/user.js";
import { User, IRemoteUser } from "@/models/entities/user.js";
import type { UserPublickey } from "@/models/entities/user-publickey.js"; import type { UserPublickey } from "@/models/entities/user-publickey.js";
import type { MessagingMessage } from "@/models/entities/messaging-message.js"; import type { MessagingMessage } from "@/models/entities/messaging-message.js";
import { import {
@ -20,8 +19,11 @@ import type { IObject } from "./type.js";
import { getApId } from "./type.js"; import { getApId } from "./type.js";
import { resolvePerson } from "./models/person.js"; import { resolvePerson } from "./models/person.js";
const publicKeyCache = new Cache<UserPublickey | null>(Infinity); const publicKeyCache = new Cache<UserPublickey | null>("publicKey", 60 * 30);
const publicKeyByUserIdCache = new Cache<UserPublickey | null>(Infinity); const publicKeyByUserIdCache = new Cache<UserPublickey | null>(
"publicKeyByUserId",
60 * 30,
);
export type UriParseResult = export type UriParseResult =
| { | {
@ -123,17 +125,23 @@ export default class DbResolver {
if (parsed.type !== "users") return null; if (parsed.type !== "users") return null;
return ( return (
(await userByIdCache.fetchMaybe(parsed.id, () => (await userByIdCache.fetchMaybe(
parsed.id,
() =>
Users.findOneBy({ Users.findOneBy({
id: parsed.id, id: parsed.id,
}).then((x) => x ?? undefined), }).then((x) => x ?? undefined),
true,
)) ?? null )) ?? null
); );
} else { } else {
return await uriPersonCache.fetch(parsed.uri, () => return await uriPersonCache.fetch(
parsed.uri,
() =>
Users.findOneBy({ Users.findOneBy({
uri: parsed.uri, uri: parsed.uri,
}), }),
true,
); );
} }
} }
@ -156,14 +164,17 @@ export default class DbResolver {
return key; return key;
}, },
true,
(key) => key != null, (key) => key != null,
); );
if (key == null) return null; if (key == null) return null;
return { return {
user: (await userByIdCache.fetch(key.userId, () => user: (await userByIdCache.fetch(
Users.findOneByOrFail({ id: key.userId }), key.userId,
() => Users.findOneByOrFail({ id: key.userId }),
true,
)) as CacheableRemoteUser, )) as CacheableRemoteUser,
key, key,
}; };
@ -183,6 +194,7 @@ export default class DbResolver {
const key = await publicKeyByUserIdCache.fetch( const key = await publicKeyByUserIdCache.fetch(
user.id, user.id,
() => UserPublickeys.findOneBy({ userId: user.id }), () => UserPublickeys.findOneBy({ userId: user.id }),
true,
(v) => v != null, (v) => v != null,
); );

View File

@ -135,14 +135,14 @@ export async function fetchPerson(
): Promise<CacheableUser | null> { ): Promise<CacheableUser | null> {
if (typeof uri !== "string") throw new Error("uri is not string"); if (typeof uri !== "string") throw new Error("uri is not string");
const cached = uriPersonCache.get(uri); const cached = await uriPersonCache.get(uri, true);
if (cached) return cached; if (cached) return cached;
// Fetch from the database if the URI points to this server // Fetch from the database if the URI points to this server
if (uri.startsWith(`${config.url}/`)) { if (uri.startsWith(`${config.url}/`)) {
const id = uri.split("/").pop(); const id = uri.split("/").pop();
const u = await Users.findOneBy({ id }); const u = await Users.findOneBy({ id });
if (u) uriPersonCache.set(uri, u); if (u) await uriPersonCache.set(uri, u);
return u; return u;
} }
@ -150,7 +150,7 @@ export async function fetchPerson(
const exist = await Users.findOneBy({ uri }); const exist = await Users.findOneBy({ uri });
if (exist) { if (exist) {
uriPersonCache.set(uri, exist); await uriPersonCache.set(uri, exist);
return exist; return exist;
} }
//#endregion //#endregion

View File

@ -9,7 +9,7 @@ import {
localUserByNativeTokenCache, localUserByNativeTokenCache,
} from "@/services/user-cache.js"; } from "@/services/user-cache.js";
const appCache = new Cache<App>(Infinity); const appCache = new Cache<App>("app", 60 * 30);
export class AuthenticationError extends Error { export class AuthenticationError extends Error {
constructor(message: string) { constructor(message: string) {
@ -49,6 +49,7 @@ export default async (
const user = await localUserByNativeTokenCache.fetch( const user = await localUserByNativeTokenCache.fetch(
token, token,
() => Users.findOneBy({ token }) as Promise<ILocalUser | null>, () => Users.findOneBy({ token }) as Promise<ILocalUser | null>,
true,
); );
if (user == null) { if (user == null) {
@ -82,11 +83,14 @@ export default async (
Users.findOneBy({ Users.findOneBy({
id: accessToken.userId, id: accessToken.userId,
}) as Promise<ILocalUser>, }) as Promise<ILocalUser>,
true,
); );
if (accessToken.appId) { if (accessToken.appId) {
const app = await appCache.fetch(accessToken.appId, () => const app = await appCache.fetch(
Apps.findOneByOrFail({ id: accessToken.appId! }), accessToken.appId,
() => Apps.findOneByOrFail({ id: accessToken.appId! }),
true,
); );
return [ return [

View File

@ -6,7 +6,7 @@ import { ApiError } from "../../../error.js";
import rndstr from "rndstr"; import rndstr from "rndstr";
import { publishBroadcastStream } from "@/services/stream.js"; import { publishBroadcastStream } from "@/services/stream.js";
import { db } from "@/db/postgre.js"; import { db } from "@/db/postgre.js";
import { type Size, getEmojiSize } from "@/misc/emoji-meta.js"; import { getEmojiSize } from "@/misc/emoji-meta.js";
export const meta = { export const meta = {
tags: ["admin"], tags: ["admin"],
@ -40,12 +40,7 @@ export default define(meta, paramDef, async (ps, me) => {
? file.name.split(".")[0] ? file.name.split(".")[0]
: `_${rndstr("a-z0-9", 8)}_`; : `_${rndstr("a-z0-9", 8)}_`;
let size: Size = { width: 0, height: 0 }; const size = await getEmojiSize(file.url);
try {
size = await getEmojiSize(file.url);
} catch {
/* skip if any error happens */
}
const emoji = await Emojis.insert({ const emoji = await Emojis.insert({
id: genId(), id: genId(),

View File

@ -6,7 +6,7 @@ import type { DriveFile } from "@/models/entities/drive-file.js";
import { uploadFromUrl } from "@/services/drive/upload-from-url.js"; import { uploadFromUrl } from "@/services/drive/upload-from-url.js";
import { publishBroadcastStream } from "@/services/stream.js"; import { publishBroadcastStream } from "@/services/stream.js";
import { db } from "@/db/postgre.js"; import { db } from "@/db/postgre.js";
import { type Size, getEmojiSize } from "@/misc/emoji-meta.js"; import { getEmojiSize } from "@/misc/emoji-meta.js";
export const meta = { export const meta = {
tags: ["admin"], tags: ["admin"],
@ -65,12 +65,7 @@ export default define(meta, paramDef, async (ps, me) => {
throw new ApiError(); throw new ApiError();
} }
let size: Size = { width: 0, height: 0 }; const size = await getEmojiSize(driveFile.url);
try {
size = await getEmojiSize(driveFile.url);
} catch {
/* skip if any error happens */
}
const copied = await Emojis.insert({ const copied = await Emojis.insert({
id: genId(), id: genId(),

View File

@ -100,7 +100,10 @@ const nodeinfo2 = async () => {
}; };
}; };
const cache = new Cache<Awaited<ReturnType<typeof nodeinfo2>>>(1000 * 60 * 10); const cache = new Cache<Awaited<ReturnType<typeof nodeinfo2>>>(
"nodeinfo",
60 * 10,
);
router.get(nodeinfo2_1path, async (ctx) => { router.get(nodeinfo2_1path, async (ctx) => {
const base = await cache.fetch(null, () => nodeinfo2()); const base = await cache.fetch(null, () => nodeinfo2());

View File

@ -25,12 +25,12 @@ export default class ActiveUsersChart extends Chart<typeof schema> {
return {}; return {};
} }
public async read(user: { public read(user: {
id: User["id"]; id: User["id"];
host: null; host: null;
createdAt: User["createdAt"]; createdAt: User["createdAt"];
}): Promise<void> { }) {
await this.commit({ this.commit({
read: [user.id], read: [user.id],
registeredWithinWeek: registeredWithinWeek:
Date.now() - user.createdAt.getTime() < week ? [user.id] : [], Date.now() - user.createdAt.getTime() < week ? [user.id] : [],

View File

@ -6,10 +6,10 @@ import { IsNull } from "typeorm";
const ACTOR_USERNAME = "instance.actor" as const; const ACTOR_USERNAME = "instance.actor" as const;
const cache = new Cache<ILocalUser>(Infinity); const cache = new Cache<ILocalUser>("instanceActor", 60 * 30);
export async function getInstanceActor(): Promise<ILocalUser> { export async function getInstanceActor(): Promise<ILocalUser> {
const cached = cache.get(null); const cached = await cache.get(null, true);
if (cached) return cached; if (cached) return cached;
const user = (await Users.findOneBy({ const user = (await Users.findOneBy({
@ -18,11 +18,11 @@ export async function getInstanceActor(): Promise<ILocalUser> {
})) as ILocalUser | undefined; })) as ILocalUser | undefined;
if (user) { if (user) {
cache.set(null, user); await cache.set(null, user);
return user; return user;
} else { } else {
const created = (await createSystemUser(ACTOR_USERNAME)) as ILocalUser; const created = (await createSystemUser(ACTOR_USERNAME)) as ILocalUser;
cache.set(null, created); await cache.set(null, created);
return created; return created;
} }
} }

View File

@ -29,17 +29,14 @@ import {
Notes, Notes,
Instances, Instances,
UserProfiles, UserProfiles,
Antennas,
Followings,
MutedNotes, MutedNotes,
Channels, Channels,
ChannelFollowings, ChannelFollowings,
Blockings,
NoteThreadMutings, NoteThreadMutings,
} from "@/models/index.js"; } from "@/models/index.js";
import type { DriveFile } from "@/models/entities/drive-file.js"; import type { DriveFile } from "@/models/entities/drive-file.js";
import type { App } from "@/models/entities/app.js"; import type { App } from "@/models/entities/app.js";
import { Not, In, IsNull } from "typeorm"; import { Not, In } from "typeorm";
import type { User, ILocalUser, IRemoteUser } from "@/models/entities/user.js"; import type { User, ILocalUser, IRemoteUser } from "@/models/entities/user.js";
import { genId } from "@/misc/gen-id.js"; import { genId } from "@/misc/gen-id.js";
import { import {
@ -73,7 +70,7 @@ import { Mutex } from "redis-semaphore";
const mutedWordsCache = new Cache< const mutedWordsCache = new Cache<
{ userId: UserProfile["userId"]; mutedWords: UserProfile["mutedWords"] }[] { userId: UserProfile["userId"]; mutedWords: UserProfile["mutedWords"] }[]
>(1000 * 60 * 5); >("mutedWords", 60 * 5);
type NotificationType = "reply" | "renote" | "quote" | "mention"; type NotificationType = "reply" | "renote" | "quote" | "mention";

View File

@ -4,30 +4,30 @@ import { genId } from "@/misc/gen-id.js";
import { toPuny } from "@/misc/convert-host.js"; import { toPuny } from "@/misc/convert-host.js";
import { Cache } from "@/misc/cache.js"; import { Cache } from "@/misc/cache.js";
const cache = new Cache<Instance>(1000 * 60 * 60); const cache = new Cache<Instance>("registerOrFetchInstanceDoc", 60 * 60);
export async function registerOrFetchInstanceDoc( export async function registerOrFetchInstanceDoc(
host: string, host: string,
): Promise<Instance> { ): Promise<Instance> {
host = toPuny(host); const _host = toPuny(host);
const cached = cache.get(host); const cached = await cache.get(_host);
if (cached) return cached; if (cached) return cached;
const index = await Instances.findOneBy({ host }); const index = await Instances.findOneBy({ host: _host });
if (index == null) { if (index == null) {
const i = await Instances.insert({ const i = await Instances.insert({
id: genId(), id: genId(),
host, host: _host,
caughtAt: new Date(), caughtAt: new Date(),
lastCommunicatedAt: new Date(), lastCommunicatedAt: new Date(),
}).then((x) => Instances.findOneByOrFail(x.identifiers[0])); }).then((x) => Instances.findOneByOrFail(x.identifiers[0]));
cache.set(host, i); await cache.set(_host, i);
return i; return i;
} else { } else {
cache.set(host, index); await cache.set(_host, index);
return index; return index;
} }
} }

View File

@ -15,7 +15,7 @@ import { createSystemUser } from "./create-system-user.js";
const ACTOR_USERNAME = "relay.actor" as const; const ACTOR_USERNAME = "relay.actor" as const;
const relaysCache = new Cache<Relay[]>(1000 * 60 * 10); const relaysCache = new Cache<Relay[]>("relay", 60 * 10);
export async function getRelayActor(): Promise<ILocalUser> { export async function getRelayActor(): Promise<ILocalUser> {
const user = await Users.findOneBy({ const user = await Users.findOneBy({
@ -90,7 +90,7 @@ async function updateRelaysCache() {
const relays = await Relays.findBy({ const relays = await Relays.findBy({
status: "accepted", status: "accepted",
}); });
relaysCache.set(null, relays); await relaysCache.set(null, relays);
} }
export async function relayRejected(id: string) { export async function relayRejected(id: string) {

View File

@ -3,17 +3,23 @@ import type {
CacheableUser, CacheableUser,
ILocalUser, ILocalUser,
} from "@/models/entities/user.js"; } from "@/models/entities/user.js";
import { User } from "@/models/entities/user.js";
import { Users } from "@/models/index.js"; import { Users } from "@/models/index.js";
import { Cache } from "@/misc/cache.js"; import { Cache } from "@/misc/cache.js";
import { subscriber } from "@/db/redis.js"; import { redisClient, subscriber } from "@/db/redis.js";
export const userByIdCache = new Cache<CacheableUser>(Infinity); export const userByIdCache = new Cache<CacheableUser>("userById", 60 * 30);
export const localUserByNativeTokenCache = new Cache<CacheableLocalUser | null>( export const localUserByNativeTokenCache = new Cache<CacheableLocalUser | null>(
Infinity, "localUserByNativeToken",
60 * 30,
);
export const localUserByIdCache = new Cache<CacheableLocalUser>(
"localUserByIdCache",
60 * 30,
);
export const uriPersonCache = new Cache<CacheableUser | null>(
"uriPerson",
60 * 30,
); );
export const localUserByIdCache = new Cache<CacheableLocalUser>(Infinity);
export const uriPersonCache = new Cache<CacheableUser | null>(Infinity);
subscriber.on("message", async (_, data) => { subscriber.on("message", async (_, data) => {
const obj = JSON.parse(data); const obj = JSON.parse(data);
@ -22,13 +28,12 @@ subscriber.on("message", async (_, data) => {
const { type, body } = obj.message; const { type, body } = obj.message;
switch (type) { switch (type) {
case "localUserUpdated": { case "localUserUpdated": {
userByIdCache.delete(body.id); await userByIdCache.delete(body.id);
localUserByIdCache.delete(body.id); await localUserByIdCache.delete(body.id);
localUserByNativeTokenCache.cache.forEach((v, k) => { const toDelete = Array.from(await localUserByNativeTokenCache.getAll())
if (v.value?.id === body.id) { .filter((v) => v[1]?.id === body.id)
localUserByNativeTokenCache.delete(k); .map((v) => v[0]);
} await localUserByNativeTokenCache.delete(...toDelete);
});
break; break;
} }
case "userChangeSuspendedState": case "userChangeSuspendedState":
@ -36,15 +41,17 @@ subscriber.on("message", async (_, data) => {
case "userChangeModeratorState": case "userChangeModeratorState":
case "remoteUserUpdated": { case "remoteUserUpdated": {
const user = await Users.findOneByOrFail({ id: body.id }); const user = await Users.findOneByOrFail({ id: body.id });
userByIdCache.set(user.id, user); await userByIdCache.set(user.id, user);
for (const [k, v] of uriPersonCache.cache.entries()) { const trans = redisClient.multi();
if (v.value?.id === user.id) { for (const [k, v] of (await uriPersonCache.getAll()).entries()) {
uriPersonCache.set(k, user); if (v?.id === user.id) {
await uriPersonCache.set(k, user, trans);
} }
} }
await trans.exec();
if (Users.isLocalUser(user)) { if (Users.isLocalUser(user)) {
localUserByNativeTokenCache.set(user.token, user); await localUserByNativeTokenCache.set(user.token, user);
localUserByIdCache.set(user.id, user); await localUserByIdCache.set(user.id, user);
} }
break; break;
} }
@ -52,8 +59,8 @@ subscriber.on("message", async (_, data) => {
const user = (await Users.findOneByOrFail({ const user = (await Users.findOneByOrFail({
id: body.id, id: body.id,
})) as ILocalUser; })) as ILocalUser;
localUserByNativeTokenCache.delete(body.oldToken); await localUserByNativeTokenCache.delete(body.oldToken);
localUserByNativeTokenCache.set(body.newToken, user); await localUserByNativeTokenCache.set(body.newToken, user);
break; break;
} }
default: default:

View File

@ -105,6 +105,9 @@ importers:
'@koa/router': '@koa/router':
specifier: 9.0.1 specifier: 9.0.1
version: 9.0.1 version: 9.0.1
'@msgpack/msgpack':
specifier: 3.0.0-beta2
version: 3.0.0-beta2
'@peertube/http-signature': '@peertube/http-signature':
specifier: 1.7.0 specifier: 1.7.0
version: 1.7.0 version: 1.7.0
@ -132,9 +135,6 @@ importers:
argon2: argon2:
specifier: ^0.30.3 specifier: ^0.30.3
version: 0.30.3 version: 0.30.3
async-mutex:
specifier: ^0.4.0
version: 0.4.0
autobind-decorator: autobind-decorator:
specifier: 2.4.0 specifier: 2.4.0
version: 2.4.0 version: 2.4.0
@ -786,7 +786,7 @@ importers:
version: 2.30.0 version: 2.30.0
emojilib: emojilib:
specifier: github:thatonecalculator/emojilib specifier: github:thatonecalculator/emojilib
version: github.com/thatonecalculator/emojilib/542fcc1a25003afad78f3248ceee8ac6980ddeb8 version: github.com/thatonecalculator/emojilib/06944984a61ee799b7083894258f5fa318d932d1
escape-regexp: escape-regexp:
specifier: 0.0.1 specifier: 0.0.1
version: 0.0.1 version: 0.0.1
@ -2277,6 +2277,11 @@ packages:
os-filter-obj: 2.0.0 os-filter-obj: 2.0.0
dev: true dev: true
/@msgpack/msgpack@3.0.0-beta2:
resolution: {integrity: sha512-y+l1PNV0XDyY8sM3YtuMLK5vE3/hkfId+Do8pLo/OPxfxuFAUwcGz3oiiUuV46/aBpwTzZ+mRWVMtlSKbradhw==}
engines: {node: '>= 14'}
dev: false
/@msgpackr-extract/msgpackr-extract-darwin-arm64@3.0.2: /@msgpackr-extract/msgpackr-extract-darwin-arm64@3.0.2:
resolution: {integrity: sha512-9bfjwDxIDWmmOKusUcqdS4Rw+SETlp9Dy39Xui9BEGEk19dDwH0jhipwFzEff/pFg95NKymc6TOTbRKcWeRqyQ==} resolution: {integrity: sha512-9bfjwDxIDWmmOKusUcqdS4Rw+SETlp9Dy39Xui9BEGEk19dDwH0jhipwFzEff/pFg95NKymc6TOTbRKcWeRqyQ==}
cpu: [arm64] cpu: [arm64]
@ -4496,12 +4501,6 @@ packages:
stream-exhaust: 1.0.2 stream-exhaust: 1.0.2
dev: true dev: true
/async-mutex@0.4.0:
resolution: {integrity: sha512-eJFZ1YhRR8UN8eBLoNzcDPcy/jqjsg6I1AP+KvWQX80BqOSW1oJPJXDylPUEeMr2ZQvHgnQ//Lp6f3RQ1zI7HA==}
dependencies:
tslib: 2.6.0
dev: false
/async-settle@1.0.0: /async-settle@1.0.0:
resolution: {integrity: sha512-VPXfB4Vk49z1LHHodrEQ6Xf7W4gg1w0dAPROHngx7qgDjqmIQ+fXmwgGXTW/ITLai0YLSvWepJOP9EVpMnEAcw==} resolution: {integrity: sha512-VPXfB4Vk49z1LHHodrEQ6Xf7W4gg1w0dAPROHngx7qgDjqmIQ+fXmwgGXTW/ITLai0YLSvWepJOP9EVpMnEAcw==}
engines: {node: '>= 0.10'} engines: {node: '>= 0.10'}
@ -15772,8 +15771,8 @@ packages:
url-polyfill: 1.1.12 url-polyfill: 1.1.12
dev: true dev: true
github.com/thatonecalculator/emojilib/542fcc1a25003afad78f3248ceee8ac6980ddeb8: github.com/thatonecalculator/emojilib/06944984a61ee799b7083894258f5fa318d932d1:
resolution: {tarball: https://codeload.github.com/thatonecalculator/emojilib/tar.gz/542fcc1a25003afad78f3248ceee8ac6980ddeb8} resolution: {tarball: https://codeload.github.com/thatonecalculator/emojilib/tar.gz/06944984a61ee799b7083894258f5fa318d932d1}
name: emojilib name: emojilib
version: 3.0.10 version: 3.0.10
dev: true dev: true