Madeorsk/rudeshark.net
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Log the assembled S3 url if constructing a S3 client fails.

Browse Source 
I was configuring an instance and didn't notice that I had pasted a space into the `endpoint` field. It was not obvious from the logs why the URL was invalid.
This commit is contained in:
Viv Lim 2023-07-24 20:34:37 -07:00
parent e35b38302d
commit 74179aafdf
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/backend/src/services/drive/s3.ts
View File

@ -11,6 +11,7 @@ export function getS3(meta: Meta) {
}` }`
: `${meta.objectStorageUseSSL ? "https://" : "http://"}example.net`; : `${meta.objectStorageUseSSL ? "https://" : "http://"}example.net`;
try {
return new S3({ return new S3({
endpoint: meta.objectStorageEndpoint || undefined, endpoint: meta.objectStorageEndpoint || undefined,
accessKeyId: meta.objectStorageAccessKey!, accessKeyId: meta.objectStorageAccessKey!,
@ -24,4 +25,7 @@ export function getS3(meta: Meta) {
agent: getAgentByUrl(new URL(u), !meta.objectStorageUseProxy), agent: getAgentByUrl(new URL(u), !meta.objectStorageUseProxy),
}, },
}); });
} catch (e) {
throw new Error(`Failed to construct S3 client, assembled S3 URL: ${u}\n${e}`);
}
} }