From 87b38c651f6c4f49495d1efb73f19f2d89e602be Mon Sep 17 00:00:00 2001
From: Kainoa Kanter <44733677+ThatOneCalculator@users.noreply.github.com>
Date: Fri, 15 Jul 2022 07:23:23 -0700
Subject: [PATCH] Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
---
 packages/client/package.json                    | 3 +--
 packages/client/src/components/media-banner.vue | 3 +--
 packages/client/src/components/media-video.vue  | 5 +++--
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/packages/client/package.json b/packages/client/package.json
index 0d28b6640..d1ba0ad45 100644
--- a/packages/client/package.json
+++ b/packages/client/package.json
@@ -109,6 +109,5 @@
 		"eslint-plugin-import": "2.26.0",
 		"eslint-plugin-vue": "9.2.0",
 		"start-server-and-test": "1.14.0"
-	},
-	"packageManager": "yarn@3.2.1"
+	}
 }
diff --git a/packages/client/src/components/media-banner.vue b/packages/client/src/components/media-banner.vue
index 0c44c7aae..0f878e9d9 100644
--- a/packages/client/src/components/media-banner.vue
+++ b/packages/client/src/components/media-banner.vue
@@ -7,7 +7,6 @@
 	</div>
 	<div v-else-if="media.type.startsWith('audio') && media.type !== 'audio/midi'" class="audio">
 		<audio
-			id="player"
 			ref="audioEl"
 			class="audio vlite-js"
 			:src="media.url"
@@ -49,7 +48,7 @@ function volumechange() {
 onMounted(() => {
 	if (audioEl) {
 		audioEl.volume = ColdDeviceStorage.get('mediaVolume');
-		new Vlitejs('#player');
+		new Vlitejs(audioEl);
 	}
 });
 </script>
diff --git a/packages/client/src/components/media-video.vue b/packages/client/src/components/media-video.vue
index 72b01a9a6..bd459b3eb 100644
--- a/packages/client/src/components/media-video.vue
+++ b/packages/client/src/components/media-video.vue
@@ -7,7 +7,6 @@
 </div>
 <div v-else class="kkjnbbplepmiyuadieoenjgutgcmtsvu">
 	<video
-		id="player"
 		ref="videoEl"
 		:poster="video.thumbnailUrl"
 		:title="video.comment"
@@ -34,8 +33,10 @@ const props = defineProps<{
 	video: misskey.entities.DriveFile;
 }>();
 
+const videoEl = $ref(null);
+
 onMounted(() => {
-	new Vlitejs('#player');
+	new Vlitejs(videoEl);
 });
 
 const hide = ref((defaultStore.state.nsfw === 'force') ? true : props.video.isSensitive && (defaultStore.state.nsfw !== 'ignore'));