rudeshark.net/packages/client/src/components/global
Johann150 804fa33535
refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
..
a.vue fix: Fix settings page (#8508) 2022-04-23 19:17:15 +09:00
acct.vue refactor(client): use composition api 2022-01-07 15:02:25 +09:00
ad.vue wip: refactor(client): migrate components to composition api 2022-01-16 11:02:27 +09:00
avatar.vue fix lints (#8737) 2022-05-26 22:53:09 +09:00
ellipsis.vue refactoring 2021-11-12 02:02:25 +09:00
emoji.vue fix lints (#8737) 2022-05-26 22:53:09 +09:00
error.vue refactor(client): use composition api 2022-01-07 15:02:25 +09:00
header.vue refactor: use Vite to build instead of webpack (#8575) 2022-05-01 22:51:07 +09:00
i18n.ts refactoring 2021-11-12 02:02:25 +09:00
loading.vue refactor: use css module at components/global/loading.vue (#8750) 2022-05-29 00:15:32 +09:00
misskey-flavored-markdown.vue enhance(MFM): limit large MFM (#8540) 2022-05-19 20:38:14 +09:00
spacer.vue enhance(client): tweak padding 2022-02-11 22:16:20 +09:00
sticky-container.vue refactor(client): specify global scope 2022-01-16 10:14:14 +09:00
time.vue refactor: improve code quality (#8751) 2022-05-29 15:15:52 +09:00
url.vue refactor: use Vite to build instead of webpack (#8575) 2022-05-01 22:51:07 +09:00
user-name.vue wip: refactor(client): migrate components to composition api 2022-01-16 07:47:28 +09:00