From 213b6ff6d13f32a9237b8f1add57971032df538d Mon Sep 17 00:00:00 2001 From: Moviuro Date: Sat, 14 Apr 2018 15:48:16 +0200 Subject: [PATCH] --embed-subs now implies --write-sub --write-sub was needed to generate a video file with embed subtitles anyway, so we simplify the interface --- youtube_dl/__init__.py | 1 + youtube_dl/options.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/youtube_dl/__init__.py b/youtube_dl/__init__.py index 9bb952457..fca6d196c 100644 --- a/youtube_dl/__init__.py +++ b/youtube_dl/__init__.py @@ -280,6 +280,7 @@ def _real_main(argv=None): 'format': opts.convertsubtitles, }) if opts.embedsubtitles: + opts.writesubtitles = True # Required to generate a final file with embed subtitles postprocessors.append({ 'key': 'FFmpegEmbedSubtitle', }) diff --git a/youtube_dl/options.py b/youtube_dl/options.py index 3e4ac03a2..04bd1d0ff 100644 --- a/youtube_dl/options.py +++ b/youtube_dl/options.py @@ -805,7 +805,7 @@ def parseOpts(overrideArguments=None): postproc.add_option( '--embed-subs', action='store_true', dest='embedsubtitles', default=False, - help='Embed subtitles in the video (only for mp4, webm and mkv videos)') + help='Embed subtitles in the video (only for mp4, webm and mkv videos), implies --write-sub') postproc.add_option( '--embed-thumbnail', action='store_true', dest='embedthumbnail', default=False,