1
0
mirror of https://codeberg.org/polarisfm/youtube-dl synced 2024-11-23 00:54:31 +01:00

--embed-subs now implies --write-sub

--write-sub was needed to generate a video file with embed subtitles anyway, so
we simplify the interface
This commit is contained in:
Moviuro 2018-04-14 15:48:16 +02:00
parent 68ddba20ae
commit 213b6ff6d1
No known key found for this signature in database
GPG Key ID: 3683061E9A48A99A
2 changed files with 2 additions and 1 deletions

View File

@ -280,6 +280,7 @@ def _real_main(argv=None):
'format': opts.convertsubtitles, 'format': opts.convertsubtitles,
}) })
if opts.embedsubtitles: if opts.embedsubtitles:
opts.writesubtitles = True # Required to generate a final file with embed subtitles
postprocessors.append({ postprocessors.append({
'key': 'FFmpegEmbedSubtitle', 'key': 'FFmpegEmbedSubtitle',
}) })

View File

@ -805,7 +805,7 @@ def parseOpts(overrideArguments=None):
postproc.add_option( postproc.add_option(
'--embed-subs', '--embed-subs',
action='store_true', dest='embedsubtitles', default=False, action='store_true', dest='embedsubtitles', default=False,
help='Embed subtitles in the video (only for mp4, webm and mkv videos)') help='Embed subtitles in the video (only for mp4, webm and mkv videos), implies --write-sub')
postproc.add_option( postproc.add_option(
'--embed-thumbnail', '--embed-thumbnail',
action='store_true', dest='embedthumbnail', default=False, action='store_true', dest='embedthumbnail', default=False,